Fix trycmd keygen snapshots to accept non-UTC timezone offsets#604
Open
jeffs wants to merge 1 commit intostr4d:mainfrom
Open
Fix trycmd keygen snapshots to accept non-UTC timezone offsets#604jeffs wants to merge 1 commit intostr4d:mainfrom
jeffs wants to merge 1 commit intostr4d:mainfrom
Conversation
The timestamp pattern ended with a literal Z, which only matches UTC. Since rage-keygen uses Local::now(), non-UTC systems produce offsets like -05:00, causing test failures. Remove the trailing Z so the wildcard matches any timezone suffix. Fixes str4d#562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zfrom trycmd timestamp patterns ingen-stdout.tomlandgen-output.out/key.txtrage-keygenuseschrono::Local::now(), which produces timezone offsets like-05:00on non-UTC systems; the[..]wildcard now matches bothZand offset suffixesFixes #562