Align Secret to the page size of the current system.#110
Merged
Conversation
stouset
force-pushed
the
stephen/plwuourmyvlq
branch
2 times, most recently
from
64b1baa to
8147d1d
Compare
stouset
force-pushed
the
stephen/plwuourmyvlq
branch
from
8147d1d to
c7c8900
Compare
Owner
Author
|
I hate this approach. I'm going to play around and see if I can get a |
stouset
force-pushed
the
stephen/plwuourmyvlq
branch
from
c7c8900 to
ea99880
Compare
|
Any progress on this? |
Owner
Author
|
I looked for awhile and wasn’t particularly happy with any of the options I came up with. Since I don’t have any better ideas at this point I’ll pick one and cut a release with a stopgap that isn’t ideal but at least closes the bug. |
stouset
force-pushed
the
stephen/plwuourmyvlq
branch
from
ea99880 to
50b8cc3
Compare
Closes #109. Multiple `Secret<T>` instances could previously share the same memory page. This would cause `munlock` to unlock multiple secrets at a time. With secrets aligned to page boundaries, we ensure that no two secrets can share the same page. Additionally we had detected the multiple-unlock case in Windows, which returns an error when `munlock` is called on an already-unlocked page. We swallowed errors in this case, but with this change we no longer need to do so.
stouset
force-pushed
the
stephen/plwuourmyvlq
branch
from
50b8cc3 to
f7da166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109.
Multiple
Secret<T>instances could previously share the same memory page. This would causefunlockto unlock multiple secrets at a time. With secrets aligned to page boundaries, we ensure that no two secrets can share the same page.Additionally we had detected the multiple-unlock case in Windows, which returns an error when
funlockis called on an already-unlocked page. We swallowed errors in this case, but with this change we no longer need to do so.