Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 96.64% 96.79% +0.15%
==========================================
Files 33 33
Lines 2622 2622
==========================================
+ Hits 2534 2538 +4
+ Misses 88 84 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maturity of ROCm/HIP still lacks significantly behind CUDA, but it has further improved. Especially CMake support via provided Config Mode files looks promising and has some advantages over CUDA. However, host compiler support (beyond hipcc) is still pretty much non-existent. Bump the required ROCm/HIP version to 7.1 and update the thrust module to rely on rocthrust detection. This should hopefully make the HIP backend less prone to incompatible upstream changes.
Note that the HIP backend is still considered experimental.