cmake: Link static or shared cudart library based on target type#469
Merged
cmake: Link static or shared cudart library based on target type#469
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 96.60% 96.64% +0.03%
==========================================
Files 33 33
Lines 2622 2622
==========================================
+ Hits 2533 2534 +1
+ Misses 89 88 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the shared version of the CUDA runtime library
CUDA::cudartis unconditionally linked. However, the static and shared version and incompatible to each other and it is discouraged to link against both. Since CMake implicitly uses the respective variant when linking a target with CUDA sources, building stdgpu as a static library ends up with mixing both, which may cause linker errors especially on Windows. Follow standard CMake behavior and link against the correct variant based on the selected target type.