feat: support using pre-registered license terms via licenseTermsId #677
+553
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clarity and improved documentation
…licenseTermsId inputs more robustly
…tructure in IP asset tests
…ion to ensure robust validation of license terms and configurations
… logic in IPAssetClient
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
edisonz0718,
jacob-tucker,
limengformal and
lucas2brh
as code owners
bonnie57
changed the title
…and improve IPAssetClient logic
bonnie57
changed the title
… examples and best practices for creating license terms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
licenseTermsIdoption toLicenseTermsDataInput, allowing users to attach existing pre-registered license terms instead of providing fulltermsobjectlicenseTermsIdis provided viaPiLicenseTemplateReadOnlyClient.batchMintAndRegisterIpAssetWithPilTermswhere incorrectlicenseTermsIdswere returned due to missinggetRevenueSharetransformation forcommercialRevShare