-
Notifications
You must be signed in to change notification settings - Fork 0
Enhanced SIP Template with Improved Structure and Fixed YAML #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,85 +1,220 @@ | ||
| --- | ||
| number: 'XXXXX' (update this part after PR creation) | ||
| number: 'XXXXX' | ||
| title: Title of SIP | ||
| authors: First Author's Name (author1@example.org), Second Author's name (author2@example.org) | ||
| authors: | ||
| - First Author's Name (author1@example.org) | ||
| - Second Author's name (author2@example.org) | ||
| sponsors: First Sponsor's Name (expert@example.org) | ||
| created: (fill me in with today's date, YYYY-MM-DD) | ||
| created: 'XXXXX' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| type: Standard/Ecosystem/Meta | ||
| status: Draft | ||
| supersedes: (optional - fill this in if the SIP supersedes a previous SIP) | ||
| superseded-by: (optional - fill this in if the SIP is superseded by a | ||
| subsequent SIP) | ||
| extends: (optional - fill this in if the SIP extends the design of a | ||
| previous SIP) | ||
| status: Draft/Accepted/Implemented/Released/Stagnant/Withdrawn | ||
| supersedes: null | ||
| superseded-by: null | ||
| extends: null | ||
|
Comment on lines
-8
to
+13
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, please don't remove the template helpers here |
||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| Provide a concise technical summary of the proposal in 2-3 sentences. This should be understandable to someone familiar with the Story Protocol ecosystem but not necessarily the specific problem domain. | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have limited length size that is broken here now. |
||
| ## Summary | ||
|
|
||
| Provide a brief summary of this proposal and why it's needed. Keep it | ||
| concise—details should be provided in the below sections. | ||
| Provide a brief summary of this proposal and why it's needed. Keep it concise—details should be provided in the below sections. | ||
|
|
||
| Please include links to relevant community discussion threads. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| Include links to relevant community discussion threads, Discord conversations, or forum posts. | ||
|
|
||
| ## Motivation | ||
|
|
||
| ### Problem Statement | ||
|
Check failure on line 28 in XXXXX-template.md
|
||
| Does this proposal address an existing problem or create new opportunities? | ||
| If addressing a problem, please describe it thoroughly: Who are the affected | ||
| users? Why is it problematic? What data supports this assessment? What related | ||
| work has been done? | ||
| If not addressing a problem, what new opportunities does it create? Please | ||
| provide background information, data, or context to illustrate the potential | ||
| impact. | ||
|
|
||
| What defines a successful solution for this problem? What are some examples of | ||
| use-cases benefit from this solution? Is there any important consideration | ||
| (e.g. edge cases) that should be considered? How will users (or other | ||
| contributors) benefit from this work? | ||
|
|
||
| If addressing a problem: | ||
| - Who are the affected users (developers, validators, end users, etc.)? | ||
|
Check failure on line 32 in XXXXX-template.md
|
||
| - Why is it problematic? | ||
| - What data or evidence supports this assessment? | ||
| - What is the current workaround, if any? | ||
|
|
||
| If creating opportunities: | ||
| - What new capabilities does this enable? | ||
|
Check failure on line 38 in XXXXX-template.md
|
||
| - What is the potential impact on the ecosystem? | ||
|
|
||
| ### Success Criteria | ||
|
Check failure on line 41 in XXXXX-template.md
|
||
| - What defines a successful solution? | ||
|
Check failure on line 42 in XXXXX-template.md
|
||
| - What are concrete use cases that benefit from this solution? | ||
| - What metrics will be used to measure success? | ||
|
|
||
| ### Scope and Non-Goals | ||
|
Check failure on line 46 in XXXXX-template.md
|
||
| - What is explicitly in scope for this proposal? | ||
|
Check failure on line 47 in XXXXX-template.md
|
||
| - What related issues are intentionally out of scope? | ||
|
|
||
| ## New Terminology (optional) | ||
|
|
||
| Is there any new terminology introduced with this proposal? | ||
| Define any new terms, concepts, or terminology introduced by this proposal. | ||
|
|
||
| ## Proposal | ||
| ## Specification | ||
|
|
||
| This section explains in detail the proposed changes and how they work. The | ||
| provided subsections help readers better understand and evaluate the proposal. | ||
| This section explains in detail the proposed changes and how they work. Use RFC 2119 keywords ("MUST", "SHOULD", "MAY", etc.) where appropriate. | ||
|
|
||
| The key words "MUST", "REQUIRED", ... in SIP | ||
| documents are to be interpreted as described in [RFC | ||
| 2119](https://www.ietf.org/rfc/rfc2119.txt) and [RFC | ||
| 8174](https://www.ietf.org/rfc/rfc8174.txt). | ||
| ### Technical Design | ||
|
|
||
| ### Drawbacks | ||
| Provide detailed technical specifications including: | ||
| - Protocol changes | ||
| - API modifications | ||
| - Data structures | ||
| - Message formats | ||
| - State transitions | ||
|
|
||
| Why should this *not* be done? What negative impact does it have? | ||
| ### Implementation Requirements | ||
|
|
||
| What are the key requirements any implementation must satisfy? | ||
|
|
||
| ### Reference Implementation (optional) | ||
|
|
||
| Provide pseudocode, algorithms, or implementation sketches where helpful. | ||
|
|
||
| ## Rationale and Design Decisions | ||
|
|
||
| ### Alternatives Considered | ||
|
|
||
| List any alternatives you considered but rejected, and explain why your chosen | ||
| approach is better. | ||
| List alternatives you considered but rejected, explaining why your chosen approach is superior: | ||
| - Alternative A: Description, pros, cons, why rejected | ||
| - Alternative B: Description, pros, cons, why rejected | ||
|
|
||
| ### Design Trade-offs | ||
|
|
||
| What trade-offs does this design make and why? | ||
|
|
||
| ### Drawbacks | ||
|
|
||
| Why should this *not* be done? What negative impacts might it have? | ||
|
|
||
| ## Impact Analysis | ||
|
|
||
| ### User Impact | ||
|
|
||
| What changes will users experience, and what is the rollout plan for this | ||
| feature? Does the design conform to the backwards & forwards compatibility? | ||
| - What changes will end users experience? | ||
| - How will this affect different user personas (developers, validators, IP creators, etc.)? | ||
| - What is the migration path for existing users? | ||
|
|
||
| ### Developer Impact (optional if not applicable) | ||
|
|
||
| - How does this affect SDK development? | ||
| - What new APIs or tools are needed? | ||
| - How will this impact existing development workflows? | ||
|
|
||
| ### Network Impact (optional if not applicable) | ||
|
|
||
| - How does this affect network topology, traffic patterns, or resource usage? | ||
| - What are the implications for network upgrades and governance? | ||
|
|
||
| ### Economic Impact (optional if not applicable) | ||
|
|
||
| - Does this change economic incentives or token economics? | ||
| - What are the cost implications for different network participants? | ||
| - How might this affect network value accrual? | ||
|
|
||
| ## Compatibility | ||
|
|
||
| ### Backward Compatibility | ||
|
|
||
| - Is this change backward compatible? | ||
| - If not, what is the migration strategy? | ||
| - How will legacy systems be supported? | ||
|
|
||
| ### Forward Compatibility | ||
|
|
||
| - How does this design accommodate future enhancements? | ||
| - What extensibility mechanisms are provided? | ||
|
|
||
| ### Ecosystem Integration | ||
|
|
||
| - How will this work with existing tools and infrastructure? | ||
| - What changes are needed in wallets, explorers, SDKs? | ||
| - How does this interact with other protocols in the ecosystem? | ||
|
|
||
| ## Security Considerations | ||
|
|
||
| - What are the security implications of this change? | ||
| - What new attack vectors might be introduced? | ||
| - How are these risks mitigated? | ||
| - What security assumptions does this make? | ||
| - Are there any cryptographic considerations? | ||
|
|
||
| ## Technical Impact (optional if not applicable) | ||
|
|
||
| ### Computational Impact | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is this different from Performance Implication |
||
| - Expected changes in CPU usage, memory consumption | ||
| - Gas cost implications for smart contracts | ||
| - Benchmarking methodology | ||
|
|
||
| ### Network Impact | ||
gregsantos marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Bandwidth requirements | ||
| - Latency implications | ||
| - Scalability considerations | ||
|
|
||
| ### Storage Impact | ||
| - State growth implications | ||
| - Archive node requirements | ||
|
|
||
| ## Documentation and Examples | ||
|
|
||
| ### Migration Guide (optional - required only for breaking changes) | ||
|
|
||
| If this changes existing functionality, provide: | ||
| - Step-by-step migration instructions | ||
| - Code examples showing before/after | ||
| - Timeline for deprecation of old methods | ||
|
|
||
| ## Community Consensus | ||
|
|
||
| ### Discussion Summary | ||
|
|
||
| Document community feedback and discussions: | ||
| - Links to [forum discussions](https://forum.story.foundation/), Discord conversations | ||
| - Summary of key feedback themes | ||
| - How feedback was incorporated into the design | ||
|
|
||
| ### Stakeholder Impact | ||
|
|
||
| - Which stakeholders are most affected? | ||
| - What is their level of support or concern? | ||
| - How were conflicts resolved? | ||
|
|
||
|
|
||
| ## Dependencies | ||
|
|
||
| ### Technical Dependencies | ||
|
|
||
| - Does this require changes to other components? | ||
| - What external libraries or systems are needed? | ||
| - Are there version compatibility requirements? | ||
|
|
||
| ### Process Dependencies | ||
|
|
||
| - What other SIPs must be implemented first? | ||
| - Are there coordination requirements with other teams? | ||
| - What approvals or reviews are needed? | ||
|
|
||
| ## Related Work (optional) | ||
|
|
||
| ### Prior Art | ||
|
|
||
| ### Performance Implications (optional) | ||
| - Have other networks implemented similar features? | ||
| - What can we learn from their experience? | ||
| - How does this approach differ from existing solutions? | ||
|
|
||
| What are the expected performance implications and how will they be measured? | ||
| Are microbenchmarks included to assess performance? | ||
| What end-to-end tests and benchmarks should be implemented? If these aren't | ||
| part of the initial design, what is the plan to ensure their creation? | ||
| ### Future Work | ||
|
|
||
| ### Implementation Considerations (optional) | ||
| - What related improvements could build on this? | ||
| - What issues are intentionally deferred to future proposals? | ||
|
|
||
| Is there any important aspect and details needed to implement this proposal | ||
| ## Appendices (optional) | ||
|
|
||
| ## Related Issues (optional) | ||
| ### A. Reference Materials | ||
|
|
||
| Which related issues fall outside the scope of this proposal but may be worth | ||
| exploring separately in the future? | ||
| Links to relevant specifications, papers, or documentation. | ||
|
|
||
| ## Prior Art (optional) | ||
| ### B. Change Log | ||
|
|
||
| Have other networks implemented similar ideas or features, and what has been | ||
| their community's experience? | ||
| Track major revisions to this document: | ||
| - Version 1.0 (YYYY-MM-DD): Initial draft | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we still keep the details on when to update this number