Skip to content

refactor(classNames): 🔍 ensure application to the right element#55

Draft
mitchelvanbever wants to merge 1 commit intomasterfrom
chore/extend-classname-location
Draft

refactor(classNames): 🔍 ensure application to the right element#55
mitchelvanbever wants to merge 1 commit intomasterfrom
chore/extend-classname-location

Conversation

@mitchelvanbever
Copy link
Copy Markdown
Member

We probably want to check all the components to ensure the className that is being passed from the styled function is applied to the right element. For the toggle this gave some headaches because of the nested structure of the css rules.

Fixed toggle but feel free to check/fix other components

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/storyofams/react-ui/DVpH6xvaF7X6UrB2SWM36hmzX9Ak
✅ Preview: https://react-ui-git-chore-extend-classname-location-storyofams.vercel.app

@mitchelvanbever mitchelvanbever changed the title Draft: refactor(classNames): 🔍 ensure application to the right element refactor(classNames): 🔍 ensure application to the right element Oct 22, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (5d835cc) to head (ecec737).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          29       29           
  Lines         343      343           
  Branches       80       80           
=======================================
  Hits          342      342           
  Misses          1        1           
Flag Coverage Δ
typescript ?
unittest 99.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant