nvme: Fix typo in BD_NVME_SANITIZE_STATUS_IN_PROG*R*ESS #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdded a canonical enum member Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (690)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important issue by correcting a typo in the documentation for an NVMe sanitize status enum. To prevent breaking existing code that might rely on the original misspelled enum member, a new, correctly spelled alias has been introduced. This approach ensures that the documentation is accurate while maintaining full backward compatibility for the API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix a typo in the BD_NVME_SANITIZE_STATUS_IN_PROGESS enum member. While the intent to maintain backward compatibility by keeping the old member is good, the implementation has a couple of issues. The new enum member is named BD_NVME_SANITIZE_STATUS_PROGRESS instead of the likely intended BD_NVME_SANITIZE_STATUS_IN_PROGRESS. Additionally, the documentation update replaces the entry for the old member, which could be confusing. I've provided suggestions to correct the name of the new enum member and to adjust the documentation to be clearer by adding a new entry for the new member and marking the old one as deprecated.
vojtechtrefny
force-pushed
the
master_nvme-sanitoze-progress-fix
branch
from
33afa01 to
353225f
Compare
tbzatek
reviewed
Dec 4, 2025
Member
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
I would perhaps do it the other way around - have the new name as =1 primarily and the assignment with the typo as a compat fallback...
vojtechtrefny
force-pushed
the
master_nvme-sanitoze-progress-fix
branch
from
353225f to
8eaf8e4
Compare
Unfortunately we need to keep the "progess" member as well now.
vojtechtrefny
force-pushed
the
master_nvme-sanitoze-progress-fix
branch
from
8eaf8e4 to
0e14f82
Compare
Member
Author
Makes sense, this way, it will be simple to remove it when we release libblockdev 4.0 in 10 years :-) |
Member
Author
|
Funnily enough, we only copied the typo from libnvme linux-nvme/libnvme#1094 :-) |
tbzatek
approved these changes
Dec 4, 2025
Member
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
Thanks! Would you like to fix UDisks as well? :-p
Member
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
vojtechtrefny
added a commit
to vojtechtrefny/storaged
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we need to keep the "progess" member as well now.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.