-
Notifications
You must be signed in to change notification settings - Fork 60
README: Update directions for updating documentation #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Update directions for updating documentation #1147
Conversation
Summary of ChangesHello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the development README to reflect a new, streamlined process for deploying project documentation. This change simplifies the release procedure by replacing a multi-step rsync and branch-switching method with a direct copy to the dedicated project website repository, ensuring documentation is updated more efficiently. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the developer documentation to reflect a new process for publishing documentation. The change moves from using a gh-pages branch to updating a separate repository for the project website. My feedback includes a suggestion to make the new instructions more specific, particularly regarding the commit message format, to ensure consistency and improve readability.
| - [ ] Update the documentation by copying the contents of the *docs/html* | ||
| folder to the *libblockdev* directory in the | ||
| [Storaged project website repository](https://github.com/storaged-project/storaged-project.github.io) | ||
| and commit and push the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction to 'commit and push the changes' is a bit vague. For better clarity and consistency with other release steps (e.g., line 128 which specifies a commit message format), I suggest making this instruction more specific and reformatting for readability.
| - [ ] Update the documentation by copying the contents of the *docs/html* | |
| folder to the *libblockdev* directory in the | |
| [Storaged project website repository](https://github.com/storaged-project/storaged-project.github.io) | |
| and commit and push the changes | |
| - [ ] Update the documentation by copying the contents of the *docs/html* | |
| folder to the *libblockdev* directory in the | |
| [Storaged project website repository](https://github.com/storaged-project/storaged-project.github.io), | |
| then commit with a message like 'docs(libblockdev): Update for vX.Y.Z' and push. |
No description provided.