Skip to content

Conversation

@vojtechtrefny
Copy link
Member

The issues are either fixed or the distribution is no longer tested in our CI.

The issues are either fixed or the distribution is no longer
tested in our CI.
@gemini-code-assist
Copy link

Summary of Changes

Hello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the test suite by eliminating outdated test skip configurations. By removing these no longer relevant skips, the CI system will now execute a more comprehensive set of tests, ensuring better coverage and catching potential regressions on platforms where previous issues have been resolved or are no longer part of the active testing matrix.

Highlights

  • Obsolete Test Skips Removed: Several test skip rules have been removed from tests/skip.yml. These skips were either for issues that have since been fixed or for distributions that are no longer actively tested in the CI environment.
  • NVDIMM Test Skip: The skip for nvdimm_test.NVDIMMNoDevTest.test_supported_sector_sizes on i686 architecture, previously due to 64-bit integer handling, has been removed.
  • LVM Test Skip: The skip for (lvm_test|lvm_dbus_tests).LvmNoDevTestCase.test_lvm_config on debian version 12, related to LVM config parsing, has been removed.
  • Crypto Test Skip: The skip for crypto_test.CryptoTestOpenClose.test_luks_open_close on fedora version 43, due to a cryptsetup bug, has been removed.
  • MDRAID Test Skip: The skip for mdraid_test.MDTestNominateDenominate.test_nominate_denominate on centos versions 9 and 10, related to a mdadm race condition, has been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several obsolete test skips from the tests/skip.yml configuration file. The removals are justified by the pull request description, which states that the underlying issues have been fixed or the corresponding distributions are no longer part of the CI test matrix. The changes are straightforward and correct. This cleanup helps keep the test configuration up-to-date and ensures that tests are run on platforms where they are now expected to pass. The changes look good and I have no further comments.

@vojtechtrefny vojtechtrefny merged commit 5294d3c into storaged-project:master Nov 20, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants