ci: Do not install DNF5 Python bindings on CentOS/RHEL 10#1142
Conversation
DNF5 is not available there.
Summary of ChangesHello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the continuous integration setup for CentOS/RHEL 10 test runs. The change specifically targets the DNF Python bindings, ensuring that the system installs the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the DNF Python bindings package for the RHEL-specific test plan. The change from python3-libdnf5 to python3-libdnf in plans/tests-rhel.fmf is appropriate for CentOS/RHEL 10. However, the fix appears to be incomplete as other test plans that might also run on RHEL/CentOS are not updated. Please see the specific comment for details.
| how: shell | ||
| script: | ||
| - sudo dnf install -y python3-libdnf5 'dnf-command(copr)' | ||
| - sudo dnf install -y python3-libdnf 'dnf-command(copr)' |
There was a problem hiding this comment.
This change correctly switches to python3-libdnf for this RHEL-specific test plan. However, the overall goal stated in the PR title, "Do not install DNF5 Python bindings on CentOS/RHEL 10", seems incompletely addressed. Other test plans, namely plans/blivet.fmf and plans/udisks.fmf, still reference python3-libdnf5. If these plans are intended to run on CentOS/RHEL 10, they will likely fail. To fully resolve the issue, please consider if those files need to be updated as well.
49608e3
into
storaged-project:master
Related: #1141