Conversation
Release v0.6.3
Release v0.7.0
Update actions for code coverage tests CRAN prep add codecov token to repo
v0.7.1 is on CRAN
tests/testthat/test-missing_data.R
Outdated
| death = dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death), | ||
| death = { | ||
| label <- attr(death, "label") | ||
| dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death) |
There was a problem hiding this comment.
| dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death) | |
| death <- dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death) |
-->
Test passed with 1 success 🎉.
There was a problem hiding this comment.
@DavisVaughan - I appreciate you reaching out. Happy to help. Is the issue you identified confined to the these unit tests? See inline comment.
|
Ah yes that looks like it fixed it, my bad! |
|
Cool. I will leave the PR for you to close when appropriate. Please reach out if I can help otherwise. |
|
Well, it's still needs to be merged into rifttable in some way or another right? Because without it the next release of dplyr is going to break rifttable's tests. I just had the wrong patch the first time around. |
|
Now I see. I can confirm that all units tests in {rifttable} pass, thanks to your PR, both with the latest version of {dplyr} from GitHub (commit 2be1ab6) and with v1.1.4. I will bring these changes to |
2 participants
Hi there, we are working on the next version of dplyr and your package was flagged in our reverse dependency checks.
if_else()fundamentally returns a new vector, so you can't expect it to retain arbitrary attributes likelabel. I've tried forcibly retaininglabelthrough someif_else()calls, but I'm still seeing some failures I don't understand, and I think I'll need some assistance from you to figure these out.If you really need
labelto stick around, the only way to do so is to create a new S3 class that retains it by implementing vctrs methods https://vctrs.r-lib.org/articles/s3-vector.htmldplyr will be released on January 31, 2026. If you could please send an update of your package to CRAN before then, that would help us out a lot! Thanks!