ngff.py: united keying information; added G key; able to do A+E keying now #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed unused keying dictionary parameters - R,S,T,U,W,X,Y,Z. I then united keyingSecond and keyingFirst into one dictionaries, inverted V calculation for secondKey and then inverted V (KeyCenter) parameter so that key offset parameters would be the same direction for all keys. Generating A+E card with "E" as first and "A" as second results in garbage. I also added sanity check logic that checks the key alphabetic order and reverses them if needed. I tried to read into the logic but it was a bit too much for my brain, sorry. The script works identically, from my testing, and I was finally able to generate A+E key for my project, adding this A+E key to the repo as well. You can now generate more wacky keys like E+M, thankfully, not seen in the wild and likely useless. I also added G key, just in case someone needs it in the future, G key sockets are available, after all.
Author
|
Converted to draft - seems like the A+E footprint generated had the wrong edge.cuts layer, I'll check why that happens, and perhaps it'll help me clean up the code a bit more, too. |
drawing out of first_key+second_key block into the bottom endpoint processing block, together with soldermask opening calculations. Also, refactored out duplicate arc angle definition. Adding fixed A+E footprint with this commit.
Author
|
Fixed the issue by refactoring out the bottom horizontal line generation code, and added the fixed footprint to the repo! |
Author
|
Feel free to merge this if you like it, I'll now add one more PR with some refactoring commits further based on this PR. |
…er to modify if needed.
Contributor
|
test |
Author
|
updated - all changes ready to merge in a single PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed unused keying dictionary parameters - R,S,T,U,W,X,Y,Z.
I then united keyingSecond and keyingFirst into one dictionaries,
inverted V calculation for secondKey and then inverted V (KeyCenter) parameter
so that key offset parameters would be the same direction for all keys.
Generating A+E card with "E" as first and "A" as second results in garbage.
I also added sanity check logic that checks the key alphabetic order
and reverses them if needed. I tried to read into the logic but it was
a bit too much for my brain, sorry.
The script works identically, from my testing, and I was finally able to
generate A+E key for my project, adding this A+E key to the repo as well.
You can now generate more wacky keys like E+M, thankfully, not seen
in the wild and likely useless.
I also added G key, just in case someone needs it in the future,
G key sockets are available, after all.
Thank you for your impressive work, and I hope this helps someone in the future.