Open
Conversation
SB-venkatyadavilli
requested review from
bhaskarsontakke,
lukasikp and
prafullaAtSB
❌ Deploy Preview for stoplight-elements failed.
|
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
prafullaAtSB
left a comment
prafullaAtSB
left a comment
There was a problem hiding this comment.
I can see domspurify package usage in elements core only. Why can't we add the in elements-core package.json?
Contributor
Author
@prafullaAtSB, Have moved dompurify package from global to elements-core package.json |
prafullaAtSB
approved these changes
Jul 22, 2025
Contributor
prafullaAtSB
left a comment
prafullaAtSB
left a comment
There was a problem hiding this comment.
Changes are good to go ahead.
bhaskarsontakke
approved these changes
Jul 22, 2025
bhaskarsontakke
left a comment
bhaskarsontakke
left a comment
There was a problem hiding this comment.
Thanks for addressing all the review comments. The changes look good to me
darekplawecki
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements Default PR Template
STOP-1246
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
Description
For Lack of Encoding, we have applied the fix, all user-supplied data within the parameterValues is now sanitized before being processed by the application.
How Has This Been Tested?
Tested it locally.
Screenshot(s)/recordings(s)
Input
Before
After
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.md