[time_lite][io] Fix overloaded-virtual errors in noble/jazzy#40
Open
proan wants to merge 2 commits into
Open
Conversation
Author
|
@Juancams This solution is very similar to yours, but I didn't need to add the additional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building on ROS 2 Jazzy and Ubuntu Noble, I see a similar error as the one in the Build Farm ( https://build.ros2.org/job/Jbin_uN64__ecl_time_lite__ubuntu_noble_amd64__binary/197/console ):
I presume the intention of the
operator=in the base class is to use that implementation in the derived classes, so I have made that explicit through theusingnotation.I have tested this on my Kobuki using a dockerfile and I have verified that it builds on Humble, Iron, and Jazzy. I can control my Kobuki using teleop_twist_keyboard. Dockerfile is here: https://github.com/ingotrobotics/turtlebot2_ros2/blob/feature/build_on_jazzy/turtlebot2_ros2.dockerfile
This is part of a series of small bug fixes to get the Turtlebot2 running in Jazzy.