Skip to content

[time_lite][io] Fix overloaded-virtual errors in noble/jazzy#40

Open
proan wants to merge 2 commits into
stonier:develfrom
ingotrobotics:bugfix/jazzy_error_overloaded-virtual
Open

[time_lite][io] Fix overloaded-virtual errors in noble/jazzy#40
proan wants to merge 2 commits into
stonier:develfrom
ingotrobotics:bugfix/jazzy_error_overloaded-virtual

Conversation

@proan
Copy link
Copy Markdown

@proan proan commented Nov 22, 2024

When building on ROS 2 Jazzy and Ubuntu Noble, I see a similar error as the one in the Build Farm ( https://build.ros2.org/job/Jbin_uN64__ecl_time_lite__ubuntu_noble_amd64__binary/197/console ):

23:07:46 /opt/ros/jazzy/include/ecl/errors/handlers.hpp:73:22: error: ‘virtual void ecl::Error::operator=(const ecl::ErrorFlag&)’ was hidden [-Werror=overloaded-virtual=]
23:07:46    73 |         virtual void operator=(const ErrorFlag &error) { error_flag = error; }
23:07:46       |                      ^~~~~~~~
23:07:46 /tmp/binarydeb/ros-jazzy-ecl-time-lite-1.2.0/src/lib/../../include/ecl/time_lite/errors.hpp:34:29: note:   by ‘ecl::TimeError::operator=’
23:07:46    34 | class ecl_time_lite_PUBLIC  TimeError : public Error {
23:07:46       |                             ^~~~~~~~~
23:07:46 cc1plus: all warnings being treated as errors

I presume the intention of the operator= in the base class is to use that implementation in the derived classes, so I have made that explicit through the using notation.

I have tested this on my Kobuki using a dockerfile and I have verified that it builds on Humble, Iron, and Jazzy. I can control my Kobuki using teleop_twist_keyboard. Dockerfile is here: https://github.com/ingotrobotics/turtlebot2_ros2/blob/feature/build_on_jazzy/turtlebot2_ros2.dockerfile

This is part of a series of small bug fixes to get the Turtlebot2 running in Jazzy.

@proan
Copy link
Copy Markdown
Author

proan commented Nov 22, 2024

@Juancams This solution is very similar to yours, but I didn't need to add the additional operator= implementation in your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant