Skip to content

Allow overriding repo owner per workspace #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skylarmacdonald wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow overriding repo owner per workspace #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions GitHub.novaextension/Scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,14 +330,14 @@ let selectedItems = {

function loadConfig() {
// 1) Owner is now mandatory
const owner = nova.config.get('github.owner');
if (!owner) {
const globalOwner = nova.config.get('github.owner');
if (!globalOwner) {
console.error('[Config] github.owner must be set');
return { token: null, owner: null, repo: null /*…*/ };
}

// 2) First try to load under the real owner
let token = nova.credentials.getPassword(CREDENTIALS_SERVICE, owner);
let token = nova.credentials.getPassword(CREDENTIALS_SERVICE, globalOwner);

// 3) If this is the first time they've set an owner,
// migrate the old “default” token over
Expand All @@ -347,15 +347,21 @@ function loadConfig() {
'default',
);
if (defaultToken) {
nova.credentials.setPassword(CREDENTIALS_SERVICE, owner, defaultToken);
nova.credentials.setPassword(CREDENTIALS_SERVICE, globalOwner, defaultToken);
nova.credentials.removePassword(CREDENTIALS_SERVICE, 'default');
token = defaultToken;
console.log(`[Config] Migrated token from “default” → “${owner}”`);
console.log(`[Config] Migrated token from “default” → “${globalOwner}”`);
}
}

if (!token) {
console.warn('[Config] No GitHub token in Keychain for owner:', owner);
console.warn('[Config] No GitHub token in Keychain for owner:', globalOwner);
}

let owner = globalOwner;
const repoOwner = nova.workspace.config.get('github.owner');
if (repoOwner != undefined) {
owner = repoOwner;
}

return {
Expand Down