ACM-34074 Test: Node.js 24 override health check (release-2.12)#6215
ACM-34074 Test: Node.js 24 override health check (release-2.12)#6215Randy424 wants to merge 3 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Randy424 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Purpose
This is a test PR — do not merge. It tests whether the npm overrides for
@openshift-console/dynamic-plugin-sdkwithin@openshift-assisted/ui-libcause issues with Node.js 24 (npm 11) during Konflux hermetic builds.Context
release-2.16. Testing older release branches.SDK → 1.0.0(ui-lib declares0.0.3)What to look for in CI
npm cipasses: Override is compatible with npm 11. ACM-34074 is unnecessary for this branch.npm cifails with network/fetch error: Override breaks hermetic build. Upstreamui-libfix needed.npm ci: Expected — this PR only swaps the base image, no code changes for Node 24 compatibility.Changes
Containerfile.acm.konflux: nodejs-20-minimal → nodejs-24-minimalContainerfile.mce.konflux: nodejs-20-minimal → nodejs-24-minimal.nvmrc: lts/iron → lts/krypton