Skip to content

ACM-34074 Test: Node.js 24 override health check (release-2.13)#6214

Draft
Randy424 wants to merge 3 commits into
release-2.13from
test/acm-34074-node24-release-2.13
Draft

ACM-34074 Test: Node.js 24 override health check (release-2.13)#6214
Randy424 wants to merge 3 commits into
release-2.13from
test/acm-34074-node24-release-2.13

Conversation

@Randy424
Copy link
Copy Markdown
Contributor

@Randy424 Randy424 commented May 15, 2026

Purpose

This is a test PR — do not merge. It tests whether the npm overrides for @openshift-console/dynamic-plugin-sdk within @openshift-assisted/ui-lib cause issues with Node.js 24 (npm 11) during Konflux hermetic builds.

Context

  • Jira: ACM-34074
  • Kevin confirmed this works on release-2.16. Testing older release branches.
  • This branch has overrides: SDK → 1.0.0, monaco-editor → ^0.34.1 (ui-lib declares SDK 0.0.3)

What to look for in CI

  • npm ci passes: Override is compatible with npm 11. ACM-34074 is unnecessary for this branch.
  • npm ci fails with network/fetch error: Override breaks hermetic build. Upstream ui-lib fix needed.
  • Build fails after npm ci: Expected — this PR only swaps the base image, no code changes for Node 24 compatibility.

Changes

  • Containerfile.acm.konflux: nodejs-20-minimal → nodejs-24-minimal
  • Containerfile.mce.konflux: nodejs-20-minimal → nodejs-24-minimal
  • .nvmrc: lts/iron → lts/krypton

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 0f92c91a-3b8a-4364-b7e6-cf36dc08aa2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/acm-34074-node24-release-2.13

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 3a25d48 ACM-34074 Test: Update Containerfile.acm.konflux to nodejs-24
  • 0d1824c ACM-34074 Test: Update Containerfile.mce.konflux to nodejs-24
  • 50a9cb4 ACM-34074 Test: Update .nvmrc to lts/krypton (Node 24)
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Randy424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant