Skip to content

Commit c787a8b

Browse files
committed
Fix release asset collisions for prebuild uploads
1 parent 4ffe120 commit c787a8b

2 files changed

Lines changed: 26 additions & 2 deletions

File tree

.github/workflows/tagged_release.yaml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,23 @@ jobs:
116116
- name: Pack release tarball
117117
run: npm pack
118118

119+
- name: Prepare release assets
120+
shell: bash
121+
run: |
122+
mkdir -p release-assets
123+
cp ./*.tgz release-assets/
124+
for target in prebuilds/*; do
125+
[ -d "$target" ] || continue
126+
target_name=$(basename "$target")
127+
(cd prebuilds && zip -r "../release-assets/prebuilds-${target_name}.zip" "$target_name")
128+
done
129+
ls -la release-assets
130+
119131
- name: Create GitHub release
120132
uses: softprops/action-gh-release@v2
121133
with:
122134
files: |
123-
*.tgz
124-
prebuilds/**/*.node
135+
release-assets/*
125136
126137
- name: Publish tagged release
127138
run: npm publish --provenance

RUNNER-FIX-HISTORY.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,19 @@ This file records the CI/workflow fix iterations so another agent can continue f
401401
- removed `NPM_RELEASE_PUBLISH_TOKEN`-based auth check step.
402402
- removed conditional publish gate tied to token validation.
403403
- switched publish command to `npm publish --provenance` (OIDC-compatible publish path).
404+
405+
### Iteration AJ (in progress)
406+
- GitHub run checked: `22651972932` (`Build & Publish tagged release`) for tag `v0.4.3`.
407+
- Outcome:
408+
- publish job failed in `Create GitHub release`.
409+
- root cause: duplicate asset names (`node-native-ocr.node`) from `prebuilds/**/*.node` upload pattern cause release-asset collision (`Not Found` from release asset update path).
410+
- Current local fix:
411+
- `.github/workflows/tagged_release.yaml`
412+
- add `Prepare release assets` step that creates uniquely named archives:
413+
- `prebuilds-darwin-arm64.zip`
414+
- `prebuilds-darwin-x64.zip`
415+
- `prebuilds-win32-x64.zip`
416+
- upload only `release-assets/*` in `softprops/action-gh-release`.
404417
## Current Hypothesis
405418
Primary remaining blocker has shifted from crash/fatal errors to CLI capability variance on the Windows runner (notably `tsv` config availability).
406419

0 commit comments

Comments
 (0)