Skip to content

Commit 4ffe120

Browse files
committed
Use npm trusted publishing in release workflow
1 parent 199c5f4 commit 4ffe120

2 files changed

Lines changed: 9 additions & 22 deletions

File tree

.github/workflows/tagged_release.yaml

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -123,26 +123,5 @@ jobs:
123123
*.tgz
124124
prebuilds/**/*.node
125125
126-
- name: Check npm publish auth
127-
id: npm-auth
128-
shell: bash
129-
env:
130-
NODE_AUTH_TOKEN: ${{ secrets.NPM_RELEASE_PUBLISH_TOKEN }}
131-
run: |
132-
if [ -z "$NODE_AUTH_TOKEN" ]; then
133-
echo "can_publish=false" >> "$GITHUB_OUTPUT"
134-
echo "::warning::NPM_RELEASE_PUBLISH_TOKEN is not set; skipping npm publish."
135-
exit 0
136-
fi
137-
if npm whoami >/dev/null 2>&1; then
138-
echo "can_publish=true" >> "$GITHUB_OUTPUT"
139-
exit 0
140-
fi
141-
echo "can_publish=false" >> "$GITHUB_OUTPUT"
142-
echo "::warning::NPM token validation failed (expired/revoked/invalid); skipping npm publish."
143-
144126
- name: Publish tagged release
145-
if: steps.npm-auth.outputs.can_publish == 'true'
146-
run: npm publish
147-
env:
148-
NODE_AUTH_TOKEN: ${{ secrets.NPM_RELEASE_PUBLISH_TOKEN }}
127+
run: npm publish --provenance

RUNNER-FIX-HISTORY.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,14 @@ This file records the CI/workflow fix iterations so another agent can continue f
393393
- add explicit GitHub release creation step (`softprops/action-gh-release@v2`) attaching packed tarball and prebuild `.node` artifacts.
394394
- add npm auth validation step (`npm whoami`) and gate `npm publish` behind successful token check.
395395
- when npm token is missing/invalid, emit warning and skip npm publish instead of failing whole release workflow.
396+
397+
### Iteration AI (in progress)
398+
- User configured npm Trusted Publishing (GitHub OIDC), so token-based npm auth gating is no longer correct.
399+
- Current local fix:
400+
- `.github/workflows/tagged_release.yaml`
401+
- removed `NPM_RELEASE_PUBLISH_TOKEN`-based auth check step.
402+
- removed conditional publish gate tied to token validation.
403+
- switched publish command to `npm publish --provenance` (OIDC-compatible publish path).
396404
## Current Hypothesis
397405
Primary remaining blocker has shifted from crash/fatal errors to CLI capability variance on the Windows runner (notably `tsv` config availability).
398406

0 commit comments

Comments
 (0)