Conversation
rykerfish
force-pushed
the
more_timings
branch
from
248424e to
2cb8550
Compare
RaulPPelaez
approved these changes
Feb 10, 2026
Contributor
|
There seems to be a conflict, feel free to merge after addressing it! |
…CC to highlight dpstokes performance
…er timing script that measures runtime as a function of packing fraction for a fixed N by scaling L for a reviewer
rykerfish
force-pushed
the
more_timings
branch
from
2cb8550 to
b325bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added timings for the rheology and diffusion sections that were used to expand the benchmark section of the paper.
This also includes a change to the original benchmarks where particles are now placed randomly instead of in an FCC lattice. The problem with the lattice was it greatly undersold DPStokes since the lattice required large domains where DPStokes begins to slow down. Instead, random packings create denser suspensions where DPStokes obviously outperforms the other algorithms when we are into the range of tens of millions of particles.