Skip to content

Dpstokes height check #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaulPPelaez merged 2 commits into from
Sep 11, 2025
Merged

Dpstokes height check #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73490d
feat: add error checking to dpstokes domain size in z to prevent obsc…
rykerfish Sep 10, 2025
8b6362f
add test to make sure error triggers for too small of a channel
rykerfish Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions solvers/DPStokes/mobility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,17 @@ class DPStokes : public libmobility::Mobility {
this->dppar.zmax += 1.5 * this->dppar.w * h / 2;
}
real Lz = this->dppar.zmax - this->dppar.zmin;
if (Lz <= 2 * this->dppar.hydrodynamicRadius) {
throw std::runtime_error("[DPStokes] The box size in z is too small to "
"fit the particles. Try increasing zmax.");
}
real H = Lz / 2;
// sets chebyshev node spacing at its coarsest (in the middle) to be h
real nz_actual = M_PI / (asin(h / H)) + 1;

// pick nearby N such that 2(Nz-1) has two factors of 2 and is FFT
// friendly
this->dppar.nz = floor(nz_actual);
this->dppar.nz += (int)ceil(nz_actual) % 2;
// pick nearby N such that 2(Nz-1) has two factors of 2 and is FFT friendly
this->dppar.nz = (int)floor(nz_actual);
this->dppar.nz += (this->dppar.nz - 1) % 2;

dpstokes->initialize(dppar);
Mobility::initialize(ipar);
Expand Down
7 changes: 7 additions & 0 deletions tests/test_initialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,10 @@ def test_nbody_wall_height_parameter():
) # single_wall periodicity requires wall height param

solver.setParameters(wallHeight=0.5)


def test_dpstokes_narrow_channel():
solver = DPStokes("periodic", "periodic", "two_walls")
solver.setParameters(Lx=3.0, Ly=3.0, zmin=0.0, zmax=1.0)
with pytest.raises(RuntimeError, match="DPStokes"):
solver.initialize(hydrodynamicRadius=1.0, viscosity=1.0)