Skip to content

Conversation

@ryan-odea
Copy link
Contributor

@ryan-odea ryan-odea commented Feb 19, 2025

  • Added cpp backend for learner and cv.learner with slight change to the control argument - it is now passed directly to learner rather than in a list.
  • Added check if OpenMP is installed based on data.table's message

Naively running microbenchmark on my system using dat_modsim:

Threads Wall Time
R Version 1 481ms
12 Error: file(con, "w") : all connections are in use
C++ Version 1 52ms
12 15ms

So naive average speedup via single thread is x9.25

@ryan-odea
Copy link
Contributor Author

It looks like it may be failing some of the examples in the readme currently - (made a mistake in my naming conventions to be lambda1_min rather than lambda_1_min). Simple fix I can do when I have the time.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@stmcg stmcg merged commit 3eeefd1 into stmcg:main Feb 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants