Skip to content

HardwareTimer: remove usage of TIMER_OUTPUT_COMPARE mode#48

Merged
fpistm merged 2 commits into
stm32duino:masterfrom
ABOSTM:HARDWARETIMER_REMOVE_OUTPUT_COMPARE
Dec 3, 2020
Merged

HardwareTimer: remove usage of TIMER_OUTPUT_COMPARE mode#48
fpistm merged 2 commits into
stm32duino:masterfrom
ABOSTM:HARDWARETIMER_REMOVE_OUTPUT_COMPARE

Conversation

@ABOSTM
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM commented Dec 3, 2020

HardwareTimer: remove usage of TIMER_OUTPUT_COMPARE mode

With introduction of PR
stm32duino/Arduino_Core_STM32#1247
Usage of TIMER_OUTPUT_COMPARE becomes obsolete.
Note: removing setMode(1, TIMER_OUTPUT_COMPARE)
also works before PR #1247.

With introduction of PR
stm32duino/Arduino_Core_STM32#1247
Usage of TIMER_OUTPUT_COMPARE becomes obsolete.
Note: removing setMode(1, TIMER_OUTPUT_COMPARE)
also works before PR #1247.

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM requested a review from fpistm December 3, 2020 08:09
Fix astyle issue

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 1.2.0 milestone Dec 3, 2020
@fpistm fpistm merged commit 8155ff2 into stm32duino:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants