Skip to content

Hardwaretimer analogWrite() no glitch#941

Merged
fpistm merged 2 commits intostm32duino:masterfrom
ABOSTM:HARDWARETIMER_ANALOGWRITE_NO_GLITCH
Feb 17, 2020
Merged

Hardwaretimer analogWrite() no glitch#941
fpistm merged 2 commits intostm32duino:masterfrom
ABOSTM:HARDWARETIMER_ANALOGWRITE_NO_GLITCH

Conversation

@ABOSTM
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM commented Feb 17, 2020

Summary

  • HardwareTimer: Add API to get configured mode
  • analogWrite: Configure HardwareTimer mode only if not previously done
    This avoid glitch when calling analoWrite multiple time.
    Also don't start again timer otherwise ther is also some glitches

Fixes #939

This avoid glitch when calling analoWrite multiple time.
Also don't start again timer otherwise ther is also some glitches

Fixes stm32duino#939
@fpistm fpistm added the enhancement New feature or request label Feb 17, 2020
@fpistm fpistm self-requested a review February 17, 2020 16:11
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting @ktand feedback before merge.

@fpistm fpistm added this to the 1.9.0 milestone Feb 17, 2020
Copy link
Copy Markdown
Contributor

@ktand ktand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fpistm fpistm merged commit f1d475a into stm32duino:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling analogWrite multiple times causes glitches in PWM signal

3 participants