Arduino cli fix#1018
Merged
fpistm merged 2 commits intostm32duino:masterfrom Mar 28, 2020
Merged
Conversation
The folder is the sketch and it is the path to that folder that should specify as the argument to arduino-cli. Because a sketch may consist of multiple files. All source files in the sketch folder are compiled. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Issue raised here arduino/arduino-cli#355 Following the documentation https://arduino.github.io/arduino-cli/platform-specification/#recipes-to-export-compiled-binary Only one recipe.output.tmp_file and recipe.output.save_file should be defined. The ".bin" only should be copied. Now upload with arduino-cli works as "Export compiled Binary" Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
matthijskooijman
approved these changes
Mar 28, 2020
Contributor
matthijskooijman
left a comment
matthijskooijman
left a comment
There was a problem hiding this comment.
LGTM. I only looked at the platform.txt commit, not the CI commit, and did not test anything, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes the issue raised here arduino/arduino-cli#355
Following the documentation
https://arduino.github.io/arduino-cli/platform-specification/#recipes-to-export-compiled-binary
Only one
recipe.output.tmp_file andrecipe.output.save_fileshould be defined. The ".bin" only should be copied.Now upload with arduino-cli works as "Export compiled Binary".