Fix problem with interaction with selenium-standalone#3
Open
rguderlei wants to merge 1 commit intostimms:masterfrom
Open
Fix problem with interaction with selenium-standalone#3rguderlei wants to merge 1 commit intostimms:masterfrom
rguderlei wants to merge 1 commit intostimms:masterfrom
Conversation
|
@stimms Any chance this could be integrated, I ended up doing a similar fix in my local branch to eliminate some race conditions I was running into. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using selenium-standalone to start/stop selenium around invoking intern. In the current version, the intern task terminates before the tests are finished. As a result, selenium is killed before the tests are completed.
The problem is solved by emitting the 'end' event when the forked intern process terminates.