Allow multiple hostnames in a single call#424
Merged
jose-caballero merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
===========================================
- Coverage 100.00% 99.88% -0.12%
===========================================
Files 109 109
Lines 2579 2598 +19
Branches 316 320 +4
===========================================
+ Hits 2579 2595 +16
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jose-caballero
force-pushed
the
allow_list_hypervisors_in_create_server_action
branch
3 times, most recently
from
db2ee12 to
f9f0192
Compare
khalford
previously requested changes
Jan 6, 2026
jose-caballero
force-pushed
the
allow_list_hypervisors_in_create_server_action
branch
from
f9f0192 to
a44a557
Compare
meoflynn
previously requested changes
Jan 6, 2026
jose-caballero
force-pushed
the
allow_list_hypervisors_in_create_server_action
branch
from
a44a557 to
16b1ac9
Compare
khalford
reviewed
Jan 7, 2026
jose-caballero
force-pushed
the
allow_list_hypervisors_in_create_server_action
branch
3 times, most recently
from
b2dbc6c to
948cee9
Compare
Member
|
There have been lots of changes since this was opened. Has it been tested in dev? |
Contributor
Author
|
@khalford where is the documentation for that? |
Member
@jose-caballero https://stfc.atlassian.net/wiki/spaces/SC/pages/569507848/Installation+and+Configuration+StackStorm We don't have documentation on testing code in dev. What you do is set up a dev StackStorm instance and run the action there. If it works, great. |
We want to be able to run the action "hv.create.test.server"
on more than one hypervisor at a time.
With this change, we allow passing more than one hostname as input option,
split by either comma or colon signs.
The execution for each individual hypervisor remains the same.
The form has also been updated to reflect the change:
* The parameter is now called "hypervisor_names", plural.
* The parameter description explains the options.
In order to facilitate this new functionality, the source code has been
refactored as follows:
* The original function "create_test_server()" has been renamed,
and a new one was added with the same name
As the original function "create_test_server()" was renamed,
the original unittest code needs to be updated to point to the new one.
The function raises an Exception when the hypervisor name is not
proper.
* A new implementation for "create_test_server()" has been created.
* An ancillary function to convert the single string with the list of
hypervisor names into a python list has been added: _str_to_list().
This ancillary function raises an Exception when both commas and
colons are used at the same time as delimiters.
* New unit tests have been added to check the new functionalities:
* verify that create_test_server() raises an Exception when the
hypervisor name is not correct:
* it is empty
* it includes a comma (,)
* it includes a colon (:)
* verity that _str_to_list() raises an Exception when commas and
colons as used at the same time.
* verify that _str_to_list() always return the expected output
jose-caballero
force-pushed
the
allow_list_hypervisors_in_create_server_action
branch
from
948cee9 to
e4d97e6
Compare
anish-mudaraddi
approved these changes
Jan 12, 2026
jose-caballero
deleted the
allow_list_hypervisors_in_create_server_action
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allow multiple hypervisor hostnames in a single call to action hv.create.test.server
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?