ENH: Add days_threshold for errored_vm schema and correct the unittests #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azahmd
force-pushed
the
test_days_threshold
branch
from
749172b to
e9070f1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 2577 2579 +2
Branches 315 316 +1
=========================================
+ Hits 2577 2579 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azahmd
force-pushed
the
test_days_threshold
branch
3 times, most recently
from
91ad008 to
4a4279d
Compare
- The email template is missing the days_threshold value - this assigns the current value of the age_filter_value to the days_threshold.
azahmd
force-pushed
the
test_days_threshold
branch
5 times, most recently
from
cbbff1e to
0af9cca
Compare
anish-mudaraddi
requested changes
Dec 17, 2025
| schema: | ||
| username: null | ||
| shutoff_table: "No Shutoff VMs" | ||
| days_threshold: "No days" |
Collaborator
There was a problem hiding this comment.
I guess this is fine, but I'd set this to 60 to match the default in the actions layer
|
|
||
| def find_shutoff_servers(cloud_account: str, from_projects: Optional[List[str]] = None): | ||
| def find_shutoff_servers( | ||
| cloud_account: str, days_threshold: int, from_projects: Optional[List[str]] = None |
Collaborator
There was a problem hiding this comment.
you should set a default days_threshold=0 here
- To make the email template show the number of days as days_threshold in email template which will will be provided in the action.
azahmd
force-pushed
the
test_days_threshold
branch
from
0af9cca to
6120bdf
Compare
gmatthews20
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?