-
Notifications
You must be signed in to change notification settings - Fork 15
590 alphanet #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
590 alphanet #644
Conversation
07dc2c0 to
6b347b1
Compare
ElliottKasoar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a list of things left to do e.g. if you add a space in between the square brackets below, it'll create a checkbox
- [] Update README
The developer guide may be slightly outdated in terms of what it suggests in terms of documenting a few model, but the main places will be the README and the user guide in docs.
We also need single point tests
| # Set before loading model to avoid type mismatches | ||
| torch.set_default_dtype(torch.float32) | ||
|
|
||
| # Default to MATPES-r2SCAN model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to really be setting a default in the same way as this would normally mean, i.e. that this is automatically downloaded/used, not just a default string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think AlphaNet doesn't call [torch.set_default_dtype()] internally, it sets [self.precision = torch.float32] but doesn't change the global default dtype?
|
Progress;
To do list
Final check
Documenting new model (check dev guide):
|
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
closes: #590