-
Notifications
You must be signed in to change notification settings - Fork 32
Acc kernel and utils file for NEMOv5 #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@arporter Updated all the changes for comment logs. Ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3130 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 376 376
Lines 53529 53529
=======================================
Hits 53484 53484
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arporter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @imaranresearch. Well done for getting the diff back to a manageable size.
Mostly it's just a matter of tidying what you have.
I'll actually try running the integration test next time around.
|
Hi @imaranresearch, unfortunately, the new integration test failed: |
|
@imaranresearch The run.stat divergence was due to using different keys in makenemo than the reference KGO. I pushed a fix for this plus some small changes to properly upload the results at the end of the workflow. Now all integration workflows are green. |
arporter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @imaranresearch and @sergisiso. It's very nearly there now. I think there just one more bit of tidying to do in the script (see inline). Integration tests all work and absolute timings are shown in the MongoDB chart. @sergisiso I guess we need to add a baseline figure somewhere to get the relative slowdown plot to work for the new series? (We should have this documented somewhere really!)
Once you've done that Imaran, please could you set the label on the PR to 'ready for review' as that makes it easier for me to spot.
No description provided.