Skip to content

Conversation

@imaranresearch
Copy link
Collaborator

No description provided.

@imaranresearch
Copy link
Collaborator Author

@arporter Updated all the changes for comment logs. Ready for review.

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (97dd02d) to head (0c8ee37).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3130   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         376      376           
  Lines       53529    53529           
=======================================
  Hits        53484    53484           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imaranresearch. Well done for getting the diff back to a manageable size.
Mostly it's just a matter of tidying what you have.
I'll actually try running the integration test next time around.

@arporter
Copy link
Member

arporter commented Oct 2, 2025

Hi @imaranresearch, unfortunately, the new integration test failed:
https://github.com/stfc/PSyclone-mirror/actions/runs/18196318722/job/51803343216#step:16:38
It looks as though it's a simple matter of a path not quite matching what is expected - have a close look at the other NEMO jobs to see what's different.

@sergisiso
Copy link
Collaborator

@imaranresearch The run.stat divergence was due to using different keys in makenemo than the reference KGO. I pushed a fix for this plus some small changes to properly upload the results at the end of the workflow. Now all integration workflows are green.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @imaranresearch and @sergisiso. It's very nearly there now. I think there just one more bit of tidying to do in the script (see inline). Integration tests all work and absolute timings are shown in the MongoDB chart. @sergisiso I guess we need to add a baseline figure somewhere to get the relative slowdown plot to work for the new series? (We should have this documented somewhere really!)

Once you've done that Imaran, please could you set the label on the PR to 'ready for review' as that makes it easier for me to spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants