Import and customise create_vm script #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New values for choices * Use IPAddressWithMaskVar * Make VM role optional
Remove IPAddress.family which was removed from Netbox data model in v2.8.0
Updated for Netbox 2.9
Custom script run() method must take a 'commit' argument
Otherwise it's possible to create objects which bypass the ORM validation rules.
Add object.full_clean() when creating objects
Also use f"..." formatting and remove unnecessary field_order
Correct way of assigning tags to objects
jrha
force-pushed
the
scripts
branch
2 times, most recently
from
c352011 to
9b530e2
Compare
drossy
reviewed
Jan 19, 2023
Member
drossy
left a comment
drossy
left a comment
There was a problem hiding this comment.
Feels like most of these could/should be a pull request against the original script. Is it feasible to make the existing fields you've made mandatory configurable somehow (via a config file possibly)?
Member
Author
|
Perhaps, I'll give it a go. |
jrha
force-pushed
the
scripts
branch
2 times, most recently
from
255c341 to
d5ab892
Compare
Also remove references to values set by commented out lines.
pep-0328
This gets passed as a keyword argument by the script framework, so has to be defined.
Member
Author
|
I've used my best Python introspection skills and turned it into a configurable monstrosity, will see about making a PR against upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.