Conversation
…n installed so no need for git to track it
Modified the mocked Endpoint for LiveView
Removed extraneous imports of React
…otentially useful for all components that use an Endpoint
…all components. started creating Stories for WithEndpoint and EventLog components Added Vitest plugin to package.json
…nt handling, for range sliders
…ore sense than the hacked enter key event that it was previously using
modified EventLog to stop showing duplicate logs
Added option to EventLog to render as just the scrolling box of Events, without the surrounding card, similar to the LiveView component
…r than affecting it directly LiveView component props simplified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook adds documentation and rendering for the components in a individualised way, similar to how Unit tests aim to test parts of code completely in isolation.
Each Story represents a single Component, and shows the various ways it may be rendered. For instance, the Live View component might be rendered as a full Card containing the image, or as just the image. Storybook aims to represent all these options.
Whilst this storybook branch may not be fully complete, with some tests missing, it has languished as a separate branch for too long, and having it will make future testing and development of components easier.
Creating a new component once storybook is implemented should be considered as a sort of Test Driven Development, where the storybook page and all the render options are defined first, and the component developed to support that.
Merging this branch may be complicated due to its age and the amount of other development that has occurred
Closes #60