fix: remove explicit node:buffer import#1061
Open
Vinzent03 wants to merge 2 commits intosteveukx:mainfrom
Open
fix: remove explicit node:buffer import#1061Vinzent03 wants to merge 2 commits intosteveukx:mainfrom
Vinzent03 wants to merge 2 commits intosteveukx:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 67c111c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this package in the Git plugin for Obsidian.md. It needs also be able to run on mobile without node (where I use another package for git instead).
With the new version of simple-git and #1049 this import was added. This causes my plugin building using esbuild and the
platformset tobrowser(instead ofnodewhich would work for desktop only where node is indeed available) to fail. By removing this explicit node import, everything seems to work great again.