Add ghostel (libghostty) terminal backend#134
Open
dakra wants to merge 1 commit intostevemolitor:mainfrom
Open
Add ghostel (libghostty) terminal backend#134dakra wants to merge 1 commit intostevemolitor:mainfrom
dakra wants to merge 1 commit intostevemolitor:mainfrom
Conversation
Implement all 10 cl-defmethod specializations for the ghostel terminal emulator, providing a third backend option alongside eat and vterm. Key design decisions: - Cannot reuse ghostel--start-process (sends stty as input, hardcodes shell command), so we call make-process directly with ghostel's filter and sentinel - Bell notification via buffer-local ring-bell-function (ghostel's native module calls ding on BEL) - Title changes inhibited in claude-code buffers via :around advice on ghostel--set-title (safe for concurrent standalone ghostel usage) - Buffer cleanup on process exit via ghostel-exit-functions hook - No pop-to-buffer/delete-window needed (unlike vterm, ghostel doesn't require a displayed window for dimensions) Also respect claude-code-toggle-auto-select during initial buffer creation, not just in the toggle command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cl-defmethodspecializations for the ghostel backend (make, send-string, kill-process, read-only/interactive mode, configure, faces, keymap, window resize)Notes
ghostel--start-processsince it hardcodes the user's shell and sends stty commands as process input.Instead calls
make-processdirectly with ghostel's filter/sentinel.ring-bell-function(ghostel's native module callsdingon BEL):aroundadvice so standalone ghostel buffers are unaffectedpop-to-buffer/delete-windowneeded unlike vterm — ghostel doesn't require a displayed window for initial dimensionsDepends on ghostel.