This repository was archived by the owner on Dec 23, 2018. It is now read-only.
Multiple formwizard instances per session#10
Open
dustinlacewell wants to merge 4 commits intostephrdev:masterfrom
dustinlacewell:master
Open
Multiple formwizard instances per session#10dustinlacewell wants to merge 4 commits intostephrdev:masterfrom dustinlacewell:master
dustinlacewell wants to merge 4 commits intostephrdev:masterfrom
dustinlacewell:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new FormWizard class and a utility class.
The new FormWizard is UniqueSessionFormWizard and it is a subclass of SessionFormWizard. The only extension is that it takes a name, which it returns when get_wizard_name is called. The utility class is called UniqueSessionFormWizardProvider and it is a view that maintains a registry of UID->UniqueSessionFormWizards. Anytime a GET request is made to the view, a new UID and corresponding wizard is created. Subsequent POST requests that contain a UID will utilize the associated wizard.
The Point:
I was using SessionFormWizard but noticed that if I was filling out a wizard on Tab1 and opened up Tab2 to the same wizard, Tab1's state was destroyed. I am developing a jQuery-ui Tab centric application so this became apparent early on. I have never submitted code to an open-source project before so if you have any comments at all just let me know and I'll try to refactor what I have to better suit your library.