-
Notifications
You must be signed in to change notification settings - Fork 2
Fix arm64 MacOS builds. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Got it, thanks for the clarification. I'll try to address this some time this week. |
9bef1db to
6b1c020
Compare
|
Hi @d4rk, thanks for the revisions! Unfortunately, I don't have a test environment for ARM64 architecture, except on my work machine. It could be some time before I can properly review the change. Is there a particular reason why you chose to write this function in assembly instead of C? |
No worries at all.
Not really, I thought it might be fun :) |
Main changes are: 1. Introduce an AARCH64 assembly version of `ft_strsplit.s`, similar to the x86_64 version. 2. Change the type of `t_bool` to `unsigned` to avoid the `single-bit-bitfield-constant-conversion` warning.
Main changes are:
ft_strsplit.ssince the x86 ASM doesn't work on ARM64.t_booltounsignedto avoid thesingle-bit-bitfield-constant-conversionwarning.