Skip to content

fix(bin): fix config merge#5

Merged
johnjenkins merged 4 commits intostenciljs:mainfrom
ThornWalli:feature/fix-config-merge
Feb 6, 2026
Merged

fix(bin): fix config merge#5
johnjenkins merged 4 commits intostenciljs:mainfrom
ThornWalli:feature/fix-config-merge

Conversation

@ThornWalli
Copy link
Contributor

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Build (pnpm build) was run locally and passed
  • Tests (pnpm test:unit) were run locally and passed
  • Tests (pnpm test:e2e) were run locally and passed
    • Unfortunately, I cannot start this process. Even without my changes.
  • Linting (pnpm lint) was run locally and passed

Pull request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes)
  • Documentation
  • Other (please describe):

What is the current behavior?

Url: https://github.com/ThornWalli/boilerplate-stencil
Branch: feature/init

I have a Stencil configuration in which I use the plugin @stencil-community/postcss.
Now, when testing with the Watch flag, I noticed that an incorrect Stencil configuration is being generated.

The problem is that you can't turn the configuration into JSON.
Reason: When using plugins, functions are included ;)

What is the new behavior?

We import the user configuration and then merge it.

    const tempConfigContent = `
    // Auto-generated temporary config by stencil-test
    // This extends your stencil config and adds watchIgnoredRegex for screenshot files

    import baseConfig from '${userConfigPath}';

    export const config = {
      ...baseConfig,
      "watchIgnoredRegex": [
        ${patternsArray}
      ]
    };
    `

Does this introduce a breaking change?

  • Yes
  • No

Copilot AI review requested due to automatic review settings February 6, 2026 13:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@johnjenkins johnjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM! One tiny thing

@johnjenkins johnjenkins merged commit 1b6ad35 into stenciljs:main Feb 6, 2026
5 of 6 checks passed
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🎉 This PR is included in version 1.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants