Skip to content

fix: guard attachShadow call for SSR DOMs without native support #6609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tysoncung wants to merge 1 commit into from
+7 −0
Closed

fix: guard attachShadow call for SSR DOMs without native support #6609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/utils/shadow-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ export function createShadowRoot(this: HTMLElement, cmpMeta: d.ComponentRuntimeM
}
}

// Guard against server-side DOM implementations (e.g. Domino) that do not
// provide `attachShadow` on host elements. In those environments we fall
// back gracefully so hydration can continue without crashing (#6605).
if (typeof this.attachShadow !== 'function') {
return;
}

const shadowRoot = this.attachShadow(opts);

// Initialize if undefined, set to CSSStyleSheet or null
Expand Down