Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes dead database-related code that is no longer used in the codebase. The cleanup focuses on removing functions that were used to populate checkpoint files from the database, along with related ledger header utilities.
Changes:
- Removed
populateCheckpointFilesFromDBand related helper functions from TransactionSQL - Removed
loadBySequence,loadMaxLedgerSeq, andcopyToStreamfrom LedgerHeaderUtils - Removed test code that tested the now-deleted
copyToStreamfunction
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/transactions/TransactionSQL.h | Removed declaration of populateCheckpointFilesFromDB function |
| src/transactions/TransactionSQL.cpp | Removed populateCheckpointFilesFromDB and helper functions (writeNonGeneralizedTxSetToStream, writeGeneralizedTxSetToStream, writeTxSetToStream, checkEncodedGeneralizedTxSetIsEmpty) |
| src/ledger/LedgerHeaderUtils.h | Removed declarations of loadBySequence, loadMaxLedgerSeq, and copyToStream functions |
| src/ledger/LedgerHeaderUtils.cpp | Removed implementations of loadBySequence, loadMaxLedgerSeq, and copyToStream functions |
| src/history/test/HistoryTests.cpp | Removed test code calling the now-deleted copyToStream function |
marta-lokhova
force-pushed
the
dbDeadCode
branch
3 times, most recently
from
fa9e94b to
40d4de6
Compare
drebelsky
reviewed
Feb 18, 2026
drebelsky
reviewed
Feb 18, 2026
marta-lokhova
force-pushed
the
dbDeadCode
branch
from
40d4de6 to
77d4051
Compare
dmkozh
approved these changes
Feb 18, 2026
drebelsky
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.