Skip to content

Command line#1732

Merged
latobarita merged 11 commits intostellar:masterfrom
vogel:command-line
Nov 30, 2018
Merged

Command line#1732
latobarita merged 11 commits intostellar:masterfrom
vogel:command-line

Conversation

@vogel
Copy link
Contributor

@vogel vogel commented Jul 24, 2018

Description

Resolves #1418

This PR implement new command-line syntax with Clara library. New command is more similar to git:

stellar-core new-db --conf testnet.cfg
stellar-core new-hist h1 h2 h3
stellar-core gen-seed --conf testnet.cfg
stellar-core run --conf testnet.cfg

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

MonsieurNicolas
MonsieurNicolas reviewed Aug 18, 2018
View reviewed changes
Copy link
Contributor

@MonsieurNicolas MonsieurNicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change overall, just looking for better namespacing and clearer help strings

@MonsieurNicolas
Copy link
Contributor

MonsieurNicolas commented Aug 18, 2018

Also note that required() is not implemented yet in Clara (catchorg/Clara#28 ) ; but you already compensate for this from what I saw.

@MonsieurNicolas
Copy link
Contributor

MonsieurNicolas commented Sep 10, 2018

@vogel : let me know when you want me to take a look again at this PR. Also, feel free to rebase/squash commits as I will probably just take a full pass anyways

@vogel vogel mentioned this pull request Nov 8, 2018
Merged
6 tasks
vogel added 8 commits November 27, 2018 23:16
@vogel
setNoListen is now member of Config class
93777a2 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
move setNoListen calls closer to application creation
7a1ee22 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
handle file "-" configuration file name in Config.cpp
a8a757e 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
move parseLedger and parseLedgerCount to CatchupConfiguration file
2003799 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
move few quorum-related functions to InferredQuorumUtils
dccc460 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
require second parameter in signtxn
45dd8a2 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
move few functions to ApplicationUtils file
3cc1f5e 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
move command line handling to DeprecatedCommandLine file
b8b1a35 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
Copy link
Contributor Author

vogel commented Nov 28, 2018

This branch is now rebased.

@MonsieurNicolas
Copy link
Contributor

MonsieurNicolas commented Nov 29, 2018

had a question in the issue #1418 (comment)

MonsieurNicolas
MonsieurNicolas reviewed Nov 29, 2018
View reviewed changes
@vogel
Copy link
Contributor Author

vogel commented Nov 29, 2018

Questions answered and updated commands.md

@MonsieurNicolas
Copy link
Contributor

MonsieurNicolas commented Nov 29, 2018

r+ 6a31e84234e2a43ecc61a5349a49b66c1c5f2229

vogel added 3 commits November 30, 2018 00:25
@vogel
implement clara-based command line handling
37a5282 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
updated docs with new command-line syntax
af832ea 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
update commands.md
8727d27 
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
Copy link
Contributor Author

vogel commented Nov 29, 2018

Formatted

@MonsieurNicolas
Copy link
Contributor

MonsieurNicolas commented Nov 29, 2018

r+ 8727d27

latobarita added a commit that referenced this pull request Nov 30, 2018
@latobarita
Merge pull request #1732 from vogel/command-line
a1df981 
Command line

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit 8727d27 into stellar:master Nov 30, 2018
@MonsieurNicolas MonsieurNicolas mentioned this pull request Nov 30, 2018
Merged
@vogel vogel deleted the command-line branch November 30, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonsieurNicolas MonsieurNicolas MonsieurNicolas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vogel @MonsieurNicolas @latobarita