Show the native contract asset address in output #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the stellar-strkey CLI tool to the Docker image build pipeline and displays the native asset contract address in the startup output. This is a preparatory step toward automatically deploying the Stellar Asset Contract for the native asset in future changes.
Key Changes:
- Adds stellar-strkey as a new dependency across all image configurations
- Implements a bash function to calculate the native asset contract address using the network ID
- Displays the calculated contract address in the startup output alongside other network information
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
start |
Adds calculate_native_asset_contract_address() function to compute the native asset contract address, displays strkey version info, and outputs the calculated contract address during startup |
images.json |
Adds stellar-strkey dependency (v0.0.14 for stable releases, main for development) to all five image configurations |
Makefile |
Extracts STRKEY_REPO and STRKEY_SHA variables from image configuration and passes them as build arguments |
Dockerfile |
Adds stellar-strkey-builder and stellar-strkey-stage build stages, copies the stellar-strkey binary to the final quickstart image |
.github/workflows/internal-build.yml |
Adds artifact download step for the strkey image to match the pattern used for other dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fnando
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add stellar-strkey CLI tool to the Docker image build pipeline. Display the native asset contract address in the startup output using the network ID and stellar-xdr/stellar-strkey tools.
Why
A first step towards automatically deploying the stellar asset contract for the native asset. It is also helpful to see the native asset contract address in the output along with the network id and network information, but the main purpose is to get that information available to the start script so that in a future change the start script can deploy that contract and knows what the address is for prebuilding the tx without simulation.
For #555