This repository was archived by the owner on Apr 23, 2024. It is now read-only.
doc: add discussion about why CAP-21 and CAP-40 are preferred over some other mechanisms#458
Open
kalepail wants to merge 7 commits intostellar-deprecated:mainfrom
Open
doc: add discussion about why CAP-21 and CAP-40 are preferred over some other mechanisms#458kalepail wants to merge 7 commits intostellar-deprecated:mainfrom
kalepail wants to merge 7 commits intostellar-deprecated:mainfrom
Conversation
kalepail
commented
Jun 15, 2022
| consumed without being successful the channel may be in a state where | ||
| participants would need to collaborate honestly to close the channel. | ||
|
|
||
| This constraint is why the protocol does not use claimable balances or |
Contributor
Author
There was a problem hiding this comment.
I don't quite understand why this has much to do with claimable balances. Or at least not from this comment. Would love more clarity over statements or when there are statements like this that clarity is added on how the logic here holds for claimable balances. Both alternative features would serve very different purposes (counter party transaction submission vs accounts) The difference in the usage of both options and the reason one would be chosen over something else is where you're losing me here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add discussion about why CAP-21 and CAP-40 are preferred over some other mechanisms.
Why
It's come up in discussion recently about how HASH_X signers could play a similar role to the signed payload signer introduced in CAP-40, and how preauthorization transactions could play a similar role as well. We made decisions not to use these existing mechanisms and it is worth capturing why, especially since those decisions have security implications.
Co-authored-by: Leigh McCulloch 351529+leighmcculloch@users.noreply.github.com