chore: bump anonymize to 1.4.9 with win32-capable text-search#185
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates @stll/anonymize to version 1.4.9 to introduce native Windows x64 support. It bumps dependencies on @stll/text-search and @stll/text-search-wasm to version 1.0.6, adding the necessary win32-x64-msvc bindings for underlying native packages like @stll/aho-corasick, @stll/fuzzy-search, and @stll/regex-set. Additionally, the bunfig.toml and lockfile are updated to accommodate these new platform-specific packages. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbaf92e45f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| 1.4.8 | |||
| 1.4.9 | |||
There was a problem hiding this comment.
Keep the WASM package version in sync
Bumping VERSION to 1.4.9 here leaves packages/anonymize/wasm/package.json at 1.4.8, and the repository’s version gate explicitly checks both runtime package files in .github/tools/sync-runtime-version.mjs. I verified that bun run check:version now fails with packages/anonymize/wasm/package.json has version 1.4.8; expected 1.4.9, so this release commit will block the documented check until the WASM package version is bumped too.
Useful? React with 👍 / 👎.
| "devDependencies": { | ||
| "@stll/anonymize-data": "workspace:*", | ||
| "@stll/text-search-wasm": "^1.0.5", | ||
| "@stll/text-search-wasm": "^1.0.6", |
There was a problem hiding this comment.
Require the new WASM search package in the published manifest
This updates only the workspace devDependency used for local builds/tests, but the package that the release workflow publishes from packages/anonymize/wasm still declares @stll/text-search-wasm as ^1.0.5. For users upgrading @stll/anonymize-wasm with an existing lockfile, 1.0.5 still satisfies that unchanged published range, so they can remain on the old WASM search stack instead of the 1.0.6 stack this release is meant to require.
Useful? React with 👍 / 👎.
cbaf92e to
ce5b050
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce5b050e43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| 1.4.8 | |||
| 1.4.9 | |||
There was a problem hiding this comment.
Sync the CLI package version as well
This bump leaves packages/cli/package.json at version 1.4.8 with @stll/anonymize pinned to ^1.4.8, but .github/tools/sync-runtime-version.mjs includes the CLI in PACKAGE_FILES and requires that dependency range to match ^${VERSION}. I ran bun run check:version and it still fails on the CLI entries, so the release/version gate remains blocked even after addressing the separate WASM package mismatch already noted.
Useful? React with 👍 / 👎.
Final link in the Windows-support chain: bumps
@stll/text-search(+ wasm) to ^1.0.6, whose native engines all shipwin32-x64-msvcbindings.@stll/anonymizenow loads natively on Windows x64.@stll/text-search^1.0.6,@stll/text-search-wasm^1.0.6, lockfile refresh*-win32-x64-msvcplatform packages to theminimumReleaseAgeExcludesfirst-party list (same rationale as the existing platform sub-package entries — without this, fresh installs hit the 5-day cooldown on our own coordinated releases)Once released, the contributor on #180 can drop the WASM test mock — the native binding will load on Windows.
CC on behalf of @jan-kubica