fix(kimi): prioritize 5-hour window in automatic mode#390
Open
ratulsarna wants to merge 4 commits intomainfrom
Open
fix(kimi): prioritize 5-hour window in automatic mode#390ratulsarna wants to merge 4 commits intomainfrom
ratulsarna wants to merge 4 commits intomainfrom
Conversation
Following the data swap in commit f14971a where rate limit became primary and weekly became secondary, update the UI labels to match: - sessionLabel (shown for primary): "Weekly" → "Rate Limit" - weeklyLabel (shown for secondary): "Rate Limit" → "Weekly" This ensures the UI displays: - "Rate Limit" label with rate limit data - "Weekly" label with weekly data Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
When rateLimitWindow is nil, set secondary to nil instead of weeklyWindow to prevent showing the same weekly metric twice under different labels. Before: - No rate limit → primary: weekly, secondary: weekly (duplicate) After: - No rate limit → primary: weekly, secondary: nil (correct) - Has rate limit → primary: rate limit, secondary: weekly (correct) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ratulsarna
force-pushed
the
codex/pr-310-audit
branch
from
76a559e to
ad6c751
Compare
ratulsarna
changed the title
Collaborator
Author
|
@ajaxjiang96 Can you verify this fixes the issue? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.Validation
pnpm checkswift test --filter StatusItemAnimationTests --filter UsageStoreCoverageTests --filter KimiUsageSnapshotConversionTests./Scripts/compile_and_run.shThanks @ajaxjiang96 for the original Kimi changes.