Use execvpe to execute zenity and kdialog#234
Open
paulfd wants to merge 1 commit intosteinbergmedia:developfrom
Open
Use execvpe to execute zenity and kdialog#234paulfd wants to merge 1 commit intosteinbergmedia:developfrom
paulfd wants to merge 1 commit intosteinbergmedia:developfrom
Conversation
Collaborator
|
@paulfd: Is 'execvpe' available on BSD? We have to make sure it works there too. |
Author
|
I'll check it out, are there any particular version/OS you're targeting? |
Author
|
Apparently it's a problem on FreeBSD so you were right to be wary! If you're OK in principle for the patch I can look into it to find a suitable, portable solution. |
Collaborator
|
Sure, a portable solution would be nice! Thanks. |
164ae64 to
2116eac
Compare
This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.
2116eac to
ebb5f66
Compare
|
I rebased the code to a recent commit, left the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.