Skip to content

Use execvpe to execute zenity and kdialog#234

Open
paulfd wants to merge 1 commit intosteinbergmedia:developfrom
sfztools:zenity-kdialog-execvp-1
Open

Use execvpe to execute zenity and kdialog#234
paulfd wants to merge 1 commit intosteinbergmedia:developfrom
sfztools:zenity-kdialog-execvp-1

Conversation

@paulfd
Copy link
Copy Markdown

@paulfd paulfd commented Oct 16, 2021

This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.

@scheffle
Copy link
Copy Markdown
Collaborator

@paulfd: Is 'execvpe' available on BSD? We have to make sure it works there too.

@paulfd
Copy link
Copy Markdown
Author

paulfd commented Oct 20, 2021

I'll check it out, are there any particular version/OS you're targeting?

@paulfd
Copy link
Copy Markdown
Author

paulfd commented Oct 20, 2021

Apparently it's a problem on FreeBSD so you were right to be wary! If you're OK in principle for the patch I can look into it to find a suitable, portable solution.

@scheffle
Copy link
Copy Markdown
Collaborator

Sure, a portable solution would be nice! Thanks.

@redtide redtide force-pushed the zenity-kdialog-execvp-1 branch 3 times, most recently from 164ae64 to 2116eac Compare May 16, 2023 07:16
This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.
@redtide redtide force-pushed the zenity-kdialog-execvp-1 branch from 2116eac to ebb5f66 Compare May 16, 2023 08:02
@redtide
Copy link
Copy Markdown

redtide commented May 16, 2023

I rebased the code to a recent commit, left the original execve for BSD and execvpe for Linux, which helps NixOS like distributions to find the KDialog/Zenity paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants