Conversation
sunkan
force-pushed
the
di-attribute
branch
2 times, most recently
from
d846217 to
4adb3c9
Compare
bix0r
reviewed
Sep 9, 2025
Member
bix0r
left a comment
bix0r
left a comment
There was a problem hiding this comment.
Looks good. I wonder if it is easy to add a test for this? If not, then don't bother
…ontext This is to allow local override of log channel. This can be needed if a class does say both payment and accounting and you want messages log to separate channels for does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.