Skip to content

Conversation

@MisterVector
Copy link
Contributor

There was already skeleton code in the launcher to rename a profile but
there was no button or actual logic to do so. A new form has been created
to assist in renaming a profile

@Davnit
Copy link
Member

Davnit commented May 6, 2018

Can you make the rename profile button not overlap the create profile button? It should look the same as remove profile.

See attached heavily enhanced screenshot.
2018-05-06_15-42-33

@Davnit Davnit self-requested a review May 6, 2018 19:44
@Davnit
Copy link
Member

Davnit commented May 6, 2018

Also instead of making a new form can we just have frmNameDialog also do this?

frmCustomInputBox from the main project might be helpful for an idea of how that could be accomplished.

@MisterVector
Copy link
Contributor Author

Fixed the buttons and re-used frmNameDialog.

@MisterVector
Copy link
Contributor Author

Anything I'm missing?

@MisterVector
Copy link
Contributor Author

What is left for this PR?

There was already skeleton code in the launcher to rename a profile but
there was no button or actual logic to do so. A new form has been created
to assist in renaming a profile
@MisterVector
Copy link
Contributor Author

Rebased on top of latest changes from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants