Skip to content

Update rpc errors to contain standard rpc error codes #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewSC208 merged 1 commit into from
Oct 7, 2025
Merged

Update rpc errors to contain standard rpc error codes #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions services/core/blueprint/key_value/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (h *rpc) Set(ctx context.Context, req *connect.Request[kvv1.SetRequest]) (*
_, err := h.controller.Set(log, key, value, 500*time.Millisecond)
if err != nil {
log.WithError(err).Error(ErrFailedSet.Error())
return nil, ErrFailedSet
return nil, connect.NewError(connect.CodeInternal, ErrFailedSet)
}

log.WithField("key", key).Debug("value saved")
Expand All @@ -75,7 +75,7 @@ func (h *rpc) Get(ctx context.Context, req *connect.Request[kvv1.GetRequest]) (*
value, err := h.controller.Get(log, key, value)
if err != nil {
log.WithError(err).Error(ErrFailedGet.Error())
return nil, ErrFailedGet
return nil, connect.NewError(connect.CodeNotFound, ErrFailedGet)
}

return connect.NewResponse(&kvv1.GetResponse{
Expand All @@ -93,7 +93,7 @@ func (h *rpc) Delete(ctx context.Context, req *connect.Request[kvv1.DeleteReques
err := h.controller.Delete(log, key, value)
if err != nil {
h.logger.WithError(err).Error(ErrFailedDelete.Error())
return nil, ErrFailedDelete
return nil, connect.NewError(connect.CodeInternal, ErrFailedDelete)
}

return connect.NewResponse(&kvv1.DeleteResponse{
Expand All @@ -110,7 +110,7 @@ func (h *rpc) List(ctx context.Context, req *connect.Request[kvv1.ListRequest])
valuesMap, err := h.controller.List(log, kind)
if err != nil {
log.WithError(err).Error(ErrFailedList.Error())
return nil, ErrFailedList
return nil, connect.NewError(connect.CodeNotFound, ErrFailedList)
}

return connect.NewResponse(&kvv1.ListResponse{
Expand Down