Skip to content

chore: propagate recent develop fixes to sibling packages (2026-06-05)#12558

Open
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-propagation-2026-06-05
Open

chore: propagate recent develop fixes to sibling packages (2026-06-05)#12558
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-propagation-2026-06-05

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between 2026-06-04 14:06:38 -0500 (39f37bf) and 2026-06-05 02:06:31 -0700 (6b0591c) to sibling packages with the same underlying defect.

Pattern: drop redundant genericndarray clause from flatten-{,from-}by overloads

typedndarray<T> already extends genericndarray<T>, making the union typedndarray<unknown> | genericndarray<unknown> in the Options<W> generic constraint redundant. The genericndarray import is retained in both files since other overloads reference it.

Pattern: PascalCase interface name in assert/is-well-formed-string

Renames interface isWellFormedString to interface IsWellFormedString in the TypeScript declaration, updating the declare var type reference accordingly; the export-value name isWellFormedString is unchanged. Aligns with every other assert/is-* package (IsString, IsBoolean, etc.) and the convention established in 608e415c.

Related Issues

None.

Questions

No.

Other

Validation

  • Search scope: per pattern, scoped to the source commit's namespace first (blas/ext/base/ndarray/* and ndarray/* for the redundant-constraint sweep; assert/is-*, array/base/cu*, math/base/special/*, and blas/ext/* for the PascalCase-interface sweep), widened to all lib/node_modules/@stdlib/**/docs/types/*.d.ts where the pattern signature warranted it.
  • Two independent opus validation passes confirmed at every candidate site that (a) the defect is present as cited, (b) surrounding context does not change the semantics — for the redundant-constraint pattern, that typedndarray<T> indeed subsumes genericndarray<T> and the simplification does not narrow accepted inputs; for the PascalCase pattern, that the docs/types/test.ts does not reference the camelCase interface name as $ExpectType, which would cascade — and (c) the proposed patch matches the source commit's exact shape.
  • A sonnet style-consistency pass verified that each replacement matches the surrounding declaration style (default = typedndarray<T> preserved on the simplified constraint, single-line overload retained, export = <value> lines untouched).

Deliberately excluded

  • fix: type orderparameter asLayout`` propagation (a601344e / `3bf760c6`): the four remaining `blas/ext/base/cartesian-` siblings (`dcartesian-power`, `scartesian-power`, `gcartesian-power`, `gcartesian-square`) already type `order` as `Layout` — no propagation sites.
  • docs: normalize dtype description in random/hypergeometric`` (fdfc2baa): the `real-valued or "generic"` defect appears nowhere else; sibling `random/*` packages either use `real-valued floating-point or "generic"` (correct prose for the `real_floating_point` dtype kind) or already use `real or "generic"` (correct for integer-output distributions).
  • docs: correct @throws description for pulse duration (b2ef3a33): the only remaining sibling, simulate/iter/pulse, validates duration >= period (not duration > period) and so the docstring must be less than the period is correct as-is — different semantics from the bartlett/hann/lanczos/etc. pulses already patched.
  • PascalCase rename for math/base/special/sincosd (Sincosd vs SinCosd), array/base/cusome (Cusome vs CuSome), and array/base/cunone (Cunone vs CuNone): one of the two validation agents flagged needs-human on each because the per-package PascalCase form requires a sibling-convention call; will land in a follow-up.
  • The active strideX/offsetX rename sweep across blas/ext/base/* (f766a248, 1a35c429, 9f94bda2, a18215d3, e74dd953, 45710f8f, 37b53d20): each remaining sibling is being landed as its own commit by the namespace owner — propagating in bulk here would duplicate that workflow.
  • Autogenerated artefacts (assert TS decls regen c415485e, REPL namespace docs ec39d31a, related-packages sections 3d01e36f, namespace list 6b0591c): generator-owned files.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to develop over the prior 24 hours. Candidate source commits were filtered for generalisable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents (two opus validation passes plus a sonnet style-consistency pass) before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits June 5, 2026 13:26
Propagates fix from 15a731b and c26d8b5 ("refactor: remove redundant
generic constraint in `blas/ext/base/ndarray/gsort{,hp}`") to the
`flattenBy` and `flattenFromBy` overloads carrying the same redundant
`typedndarray<T> | genericndarray<T>` union in a generic constraint.
The `genericndarray` clause is subsumed by `typedndarray`; the import is
retained for use by other overloads in the same file.
Propagates fix from 608e415 ("fix: rename interface to PascalCase
`LastIndexOf` in `blas/ext/last-index-of`") to the sibling
`assert/is-well-formed-string` package whose declaration file used a
camelCase interface name (`isWellFormedString`) contrary to the
PascalCase convention used by every other `assert/is-*` package.
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-well-formed-string $\color{red}334/340$
$\color{green}+98.24\%$
$\color{red}25/27$
$\color{green}+92.59\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}334/340$
$\color{green}+98.24\%$
ndarray/flatten-by $\color{green}239/239$
$\color{green}+100.00\%$
$\color{green}37/37$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}239/239$
$\color{green}+100.00\%$
ndarray/flatten-from-by $\color{green}334/334$
$\color{green}+100.00\%$
$\color{green}35/35$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}334/334$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title fix: propagate recent develop fixes to sibling packages (2026-06-05) refactor: propagate recent develop fixes to sibling packages (2026-06-05) Jun 5, 2026
@Planeshifter Planeshifter changed the title refactor: propagate recent develop fixes to sibling packages (2026-06-05) chore: propagate recent develop fixes to sibling packages (2026-06-05) Jun 5, 2026
@Planeshifter Planeshifter requested a review from kgryte June 5, 2026 15:16
@Planeshifter Planeshifter marked this pull request as ready for review June 5, 2026 15:16
@Planeshifter Planeshifter requested a review from a team June 5, 2026 15:16
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants