chore: propagate recent develop fixes to sibling packages (2026-06-05)#12558
Open
Planeshifter wants to merge 2 commits into
Open
chore: propagate recent develop fixes to sibling packages (2026-06-05)#12558Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Propagates fix from 15a731b and c26d8b5 ("refactor: remove redundant generic constraint in `blas/ext/base/ndarray/gsort{,hp}`") to the `flattenBy` and `flattenFromBy` overloads carrying the same redundant `typedndarray<T> | genericndarray<T>` union in a generic constraint. The `genericndarray` clause is subsumed by `typedndarray`; the import is retained for use by other overloads in the same file.
Propagates fix from 608e415 ("fix: rename interface to PascalCase `LastIndexOf` in `blas/ext/last-index-of`") to the sibling `assert/is-well-formed-string` package whose declaration file used a camelCase interface name (`isWellFormedString`) contrary to the PascalCase convention used by every other `assert/is-*` package.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-06-04 14:06:38 -0500 (39f37bf) and 2026-06-05 02:06:31 -0700 (6b0591c) to sibling packages with the same underlying defect.Pattern: drop redundant
genericndarrayclause fromflatten-{,from-}byoverloadstypedndarray<T>already extendsgenericndarray<T>, making the uniontypedndarray<unknown> | genericndarray<unknown>in theOptions<W>generic constraint redundant. Thegenericndarrayimport is retained in both files since other overloads reference it.15a731b9(refactor: remove redundant generic constraint inblas/ext/base/ndarray/gsorthp``)c26d8b58(refactor: remove redundant generic constraint inblas/ext/base/ndarray/gsort``)@stdlib/ndarray/flatten-by@stdlib/ndarray/flatten-from-byPattern: PascalCase interface name in
assert/is-well-formed-stringRenames
interface isWellFormedStringtointerface IsWellFormedStringin the TypeScript declaration, updating thedeclare vartype reference accordingly; the export-value nameisWellFormedStringis unchanged. Aligns with every otherassert/is-*package (IsString,IsBoolean, etc.) and the convention established in608e415c.608e415c(fix: rename interface to PascalCaseLastIndexOfinblas/ext/last-index-of``)@stdlib/assert/is-well-formed-stringRelated Issues
None.
Questions
No.
Other
Validation
blas/ext/base/ndarray/*andndarray/*for the redundant-constraint sweep;assert/is-*,array/base/cu*,math/base/special/*, andblas/ext/*for the PascalCase-interface sweep), widened to alllib/node_modules/@stdlib/**/docs/types/*.d.tswhere the pattern signature warranted it.typedndarray<T>indeed subsumesgenericndarray<T>and the simplification does not narrow accepted inputs; for the PascalCase pattern, that thedocs/types/test.tsdoes not reference the camelCase interface name as$ExpectType, which would cascade — and (c) the proposed patch matches the source commit's exact shape.= typedndarray<T>preserved on the simplified constraint, single-line overload retained,export = <value>lines untouched).Deliberately excluded
fix: typeorderparameter asLayout`` propagation (a601344e/ `3bf760c6`): the four remaining `blas/ext/base/cartesian-` siblings (`dcartesian-power`, `scartesian-power`, `gcartesian-power`, `gcartesian-square`) already type `order` as `Layout` — no propagation sites.docs: normalize dtype description inrandom/hypergeometric`` (fdfc2baa): the `real-valued or "generic"` defect appears nowhere else; sibling `random/*` packages either use `real-valued floating-point or "generic"` (correct prose for the `real_floating_point` dtype kind) or already use `real or "generic"` (correct for integer-output distributions).docs: correct@throwsdescription for pulse duration(b2ef3a33): the only remaining sibling,simulate/iter/pulse, validatesduration >= period(notduration > period) and so the docstringmust be less than the periodis correct as-is — different semantics from the bartlett/hann/lanczos/etc. pulses already patched.math/base/special/sincosd(SincosdvsSinCosd),array/base/cusome(CusomevsCuSome), andarray/base/cunone(CunonevsCuNone): one of the two validation agents flaggedneeds-humanon each because the per-package PascalCase form requires a sibling-convention call; will land in a follow-up.strideX/offsetXrename sweep acrossblas/ext/base/*(f766a248,1a35c429,9f94bda2,a18215d3,e74dd953,45710f8f,37b53d20): each remaining sibling is being landed as its own commit by the namespace owner — propagating in bulk here would duplicate that workflow.c415485e, REPL namespace docsec39d31a, related-packages sections3d01e36f, namespace list6b0591c): generator-owned files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to
developover the prior 24 hours. Candidate source commits were filtered for generalisable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents (two opus validation passes plus a sonnet style-consistency pass) before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code